Repository navigation
A malformed request to add a storage is a 400, not a panic - #1
Merged
Merged
Conversation
PostAddStorage -- the call that can format a disk -- read its body into a map and took path, name and format out with unchecked type assertions, so a field of the wrong type or a missing path panicked in the handler (Recover turned it into a 500). The body is a typed struct now: a wrong type is Bind's 400 and a missing path is the existing empty-path refusal, both before any disk is touched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostAddStorage, the call that can format a disk, read path, name and format out of a map with unchecked type assertions. A field of the wrong type or a missing path panicked in the handler, which Recover turned into a 500.
The body is a typed struct now: a wrong type is Bind's 400, and a missing path is the empty-path refusal that was already there. Both happen before any disk is touched.
Opened so the tests run on Linux.