Repository navigation
Accept readOnly fields sent back in a request - #9
Merged
Merged
Conversation
The dashboard edits what it read and sends it back whole: a backup schedule carries its last_run. The handlers ignore such fields and keep their own, but kin-openapi refuses them by default since the version this project moved to, so saving any schedule once one had run failed with "readOnly property last_run in request" (ReCasaOS/CasaOS#7). The request validator now leaves readOnly fields to the handlers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving backup schedules failed with 'readOnly property last_run in request' once a schedule had run: the dashboard sends the list back as it read it, and kin-openapi v0.149 refuses readOnly properties in requests by default. The handlers already ignore those fields, so the validator now skips that check (ExcludeReadOnlyValidations). For ReCasaOS/CasaOS#7.