Repository navigation
Never stop an app that answers DNS for its backup - #7
Merged
Merged
Conversation
A backup held still stops the app it copies. When that app is the DNS server (AdGuard Home, Pi-hole), the box loses its own lookups for the length of the copy when it uses that server, so a copy to a cloud destination fails at its first one (ReCasaOS/CasaOS#7), and the whole network loses its names meanwhile. An app that publishes port 53, or AdGuard Home or Pi-hole on the host's network, is now copied running. The History records whether the app was really stopped, not whether it was asked to be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backing up AdGuard Home or Pi-hole with hold still stopped the DNS server for the copy: the box lost its lookups and a cloud copy failed on DNS (ReCasaOS/CasaOS#7), and the whole network lost its names meanwhile. An app publishing port 53, or AdGuard Home/Pi-hole on the host network, is now copied running; the History records whether the app was really stopped.