Repository navigation
fix(image-update): leave an app built on this box out of the update check - #12
Merged
Merged
Conversation
…heck An app whose every service has a build: section, a git app or a compose file built here, runs nothing a registry publishes. The check of every app listed it among the apps it could not check, and the dashboard said so after every check: "Could not check jarvis (this app runs no image with a tag to compare). They keep their previous state." It is not a failure, and the check now leaves such an app out, as it already left out the built services of an app that pulls others. The single-app check still answers why, in plainer words.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An app whose every service is built on the box (
build:sections, as a git app) runs no image a registry publishes. The check of every app still listed it as unchecked, so after each check the dashboard reported "Could not check jarvis (this app runs no image with a tag to compare). They keep their previous state.", which reads as a failure every time.CheckImageUpdatesnow leaves such an app out, the same waypulledServiceNamesalready leaves out the built services of an app that also pulls images. An app that pulls even one image is still checked on it. The single-app check keeps answering why, with the reason reworded to "none of its services runs an image a registry publishes".Test:
TestAnAppBuiltHereIsLeftOutOfTheCheck.