Repository navigation
fix(route): the app grid gives a stack without x-casaos its image - #11
Merged
Merged
Conversation
The main service's image was copied into the grid item inside the store-info branch, so a stack written by hand arrived without one. The dashboard tells an app by its image: the Syncthing widget offered to install a Syncthing that was already running (ReCasaOS/CasaOS-UI#11). The image comes from the compose file, not the catalogue, and now always makes the trip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main service's image was set on the app grid item only when the app had store info, so a stack written by hand (no
x-casaos) had none. The dashboard recognises apps by their image: with ReCasaOS/CasaOS-UI#11, the Syncthing widget would offer to install a Syncthing that is already running from such a stack.The image now comes from the compose file for every v2 app.
TestWebAppGridItemCarriesStatusWithoutStoreInfochecks it on the vanilla compose fixture.