fixed fuzz value for material_right to match reference image#1742
Open
LBreede wants to merge 1 commit into
Open
fixed fuzz value for material_right to match reference image#1742LBreede wants to merge 1 commit into
LBreede wants to merge 1 commit into
Conversation
Collaborator
|
Please update |
There was a problem hiding this comment.
Pull request overview
Updates the Ray Tracing in One Weekend Book 1 HTML to fix a code typo in Chapter 11.5 (“Modeling a Hollow Glass Sphere”) so the listed scene matches the reference render in Image 18.
Changes:
- Set
material_rightmetalfuzzfrom0.0to1.0in Listing 79’s scene snippet to match the reference output.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In chapter 11.5. Modeling a Hollow Glass Sphere of Ray Tracing in One Weekend, there is a typo in the code.
Listing 79 highlights the changes to the dielectric material. Not highlighted, is the fuzz value of for the metal material, which has been set to
0.0. This seems to be a typo considering the line is not highlighted, and, more importantly, the reference image 18 still shows a rough metal material, indicative of a fuzz value greater than0.0.fixes #1673