Only show scroll bars for students instructions when needed - #1613
Merged
Conversation
DNR500
marked this pull request as ready for review
August 27, 2026 08:22
maxelkins
self-requested a review
August 27, 2026 08:32
maxelkins
approved these changes
Aug 27, 2026
Comment on lines
+9
to
+12
| // Student preview sizes to its content so short steps are not scrollable. | ||
| &:has(.c-instruction-tabs) { | ||
| block-size: 100%; | ||
| } |
Contributor
There was a problem hiding this comment.
Looks good.
I assume in the react component we already know when this tab is rendered - we could use a modifer class instead for slightly better browser support. Although :has() is baseline now 🤷
Contributor
Author
There was a problem hiding this comment.
:has() has been in place for a while now so I think it safe to use
jamiebenstead
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
issue: 1707
Short project instructions no longer show a scrollbar. The bar still appears when the text is too long to fit.