Update sf mapping to include code editor ExCS projects - #990
Merged
Conversation
…ect_type of code_editor_scratch
Test coverage93.5% line coverage reported by SimpleCov. |
raspberrypiherokubot
temporarily deployed
to
editor-api-p-1702-map-e-4br0mf
August 28, 2026 15:35
Inactive
cocomarine
marked this pull request as ready for review
September 1, 2026 07:41
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Salesforce Lesson sync to normalize teacherprojecttype__c for Experience CS “Code Editor Scratch” lessons so that Salesforce receives scratch rather than code_editor_scratch, aligning reporting across Experience CS project variants.
Changes:
- Route
teacherprojecttype__cthrough a newproject_type_attributehelper inSalesforce::LessonSyncJob. - Add specs to verify Experience CS-origin lesson projects sync
teacherprojecttype__casscratchforProject::EXPERIENCE_CS_PROJECT_TYPES.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/jobs/salesforce/lesson_sync_job.rb | Adds project_type_attribute and uses it when syncing teacherprojecttype__c. |
| spec/jobs/salesforce/lesson_sync_job_spec.rb | Adds coverage for Experience CS-origin projects to ensure Salesforce sees scratch. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
What's changed?
project_type_attributelogic in lesson_sync_job.rbteacherprojecttype__casscratchwhen an ExCS project has project_type of either scratch (default behaviour) or code_editor_scratch (i.e.,Project::EXPERIENCE_CS_PROJECT_TYPES)