Cover US path deterministically - #731
Conversation
- district_nces_id now generates 7 digits instead of 12 - we were using school id instead
|
We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please complete this form and we'll get you added and review your contribution as soon as possible. |
Test coverage90.06% line coverage reported by SimpleCov. |
There was a problem hiding this comment.
Pull request overview
Updates test seeding to reliably exercise the US-specific school validation path and aligns seeded US district IDs with the model’s expected format.
Changes:
- Add a
seed_country_codehook in the task spec to optionally stubFaker::Address.country_code, plus a US-specific context/assertions. - Change US
district_nces_idseed generation from 12 digits to 7 digits to match validation expectations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
spec/lib/test_seeds_spec.rb |
Adds a US-only context and stubbing mechanism to exercise US seeding behavior. |
lib/tasks/seeds_helper.rb |
Adjusts US district NCES ID generation to a 7-digit format. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| let(:seed_country_code) { nil } | ||
|
|
||
| before do | ||
| allow(Faker::Address).to receive(:country_code).and_return(seed_country_code) if seed_country_code |
|
Found issue with CLA |
No description provided.