feat: replace admin_config keypair with deterministic PDA - #27
Open
0xRektified wants to merge 1 commit into
Open
feat: replace admin_config keypair with deterministic PDA#270xRektified wants to merge 1 commit into
0xRektified wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Request: Use PDA for admin_config account
Current Implementation
The tutorial currently uses a generated keypair for the
admin_configaccount:Proposed Implementation
Use a PDA with a deterministic seed for the admin_config account:
Solana program:
Benefits
No off-chain storage required, simpler client code, no keypair generation needed only requires admin signer (not both admin and adminConfig). Better developer experience, users following the tutorial won't need to worry about storing or losing the admin config address
Changes Required
If this PR is accepted we ll need to update the following screenshot:
As i wasn't able to
Impact
This change improves the tutorial by teaching the industry standard pattern for program owned accounts, making it more aligned with real world production code.