fix: spl-token-sale-tutorial add missing helper functions in test setup - #26
Open
0xRektified wants to merge 1 commit into
Open
fix: spl-token-sale-tutorial add missing helper functions in test setup#260xRektified wants to merge 1 commit into
0xRektified wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing helper functions in token sale tutorial
Summary
This PR adds the missing helper function definitions (
toRawTokenAmount,toDisplayAmount, andlamportsToSol) that are used throughout the test cases but were never defined in the tutorial.Problem
Users following the tutorial would encounter errors when running the tests because these helper functions are called in multiple places:
lamportsToSol(solToSend)andtoDisplayAmount(expectedTokenAmount)toRawTokenAmount(1000)toDisplayAmount(currentSupply)andtoDisplayAmount(remainingSupply)toRawTokenAmount(20)lamportsToSol()callsSolution
Added three helper functions at the beginning of the test file (after imports, before the
describeblock):toRawTokenAmount(amount: number)toDisplayAmount(amount: number)lamportsToSol(lamports: number | anchor.BN)Testing
Users can now successfully run all test cases without encountering "function not defined" errors.