Repository navigation
fix(controller): bound proxy upload file-cache charges - #163
Conversation
|
@codex review Please independently review exact SOURCE 21edcfe against BASE 49da9d6, including spool byte integrity, normal EOF/error/close semantics, tmpfs/ramfs refusal, 4 MiB writeback/cache windows, unchanged request/slot/lock/uncertainty contracts, and the native regression and documentation. The source-stamped two-full-upload proof passed at 21,319,680 bytes peak cgroup memory with no OOM. The separate baseline OOM reproducer used explicitly memory-backed spooling; the live incident's filesystem backing is not established. Existing limits and source identity must remain intact. No Cursor request or duplicate independent review is intended. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Please review successor b102c93 against actual main 49da9d6. The prior required run exposed one omitted helper in the existing cleanup fixture. This successor adds that single empty mock helper, preserving all ten existing exit/status/cleanup assertions. Proxy code, module inputs, native memory regression and HOST-MAINTENANCE are byte-identical to the previously reviewed source. Review the fixture correction and retained regression integration; native proof keeps its original source stamp. No live adoption or application retry is authorized. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b102c934e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review full successor 22db077 against actual main 49da9d6. The valid SIGTERM finding is corrected using the existing fixture termination-handler pattern. A committed installed-executor regression covers cancellation through the shell with successful and failed Docker log collection; both old-helper controls fail, both fixed cases and all ten existing cleanup/status cases pass. The focused transcript is exported/hash-verified. Review cleanup and regression integration, including unchanged memory, payload, lock and uncertainty guards. No complete new-head run has started; source availability remains separate from live adoption and application retry. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Required run41568942095 attempt1 failed at the unchanged10800-second tests-and-fixtures deadline. Five prior stages and all65 local-validation tests passed; the container/native memory stage did not execute. Failed artifact13208043754 and all six recorded stage hashes are retained/verified, with scoped execution cleanup complete. The unchanged late adapter cases both passed in2.629seconds. The exact22db077 head keeps its clean independent review. One bounded existing-run retry will retain the same source/base, full coverage and10800/240min/16200 budgets. Another timeout will stop automatic retries and require a concrete performance correction; no budget increase is planned. No live adoption or application retry is released. |
|
@codex review Please review exact SOURCE 7d08ab3 against BASE 49da9d6. The new commit batches five capability probes through the existing jq prerequisite, preserves exact JSON-string capability matching and all release/helper trust checks, fails closed on reader failure, adds guard regressions, and retains the interrupted retry output on failure. The current focused executor689 proof uses this committed source with unchanged assertions/wait/budgets; full exact-head required validation remains pending. Earlier proxy/cancellation review findings remain resolved. This is the single needed successor-head independent review; no Bugbot review is requested. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review Retry the successor-head review that failed to complete at 2026-11-03T09:27:31.851739Z. SOURCE remains 7d08ab3 and BASE remains 49da9d6. No new actionable review comment or unresolved inline thread was returned. This is a retry of an incomplete review, not a replacement for a valid review. The focused committed-source checkpoint proof has now passed every original assertion, exported/verified with empty cgroups and zero containers. Nested activation took approximately54.789seconds; the unchanged-source focused measurements were66.008 and67.785seconds. All wait and suite budgets remain unchanged. Full native acceptance still waits for the completed independent review. No Bugbot action is requested. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Independent manual source review for PR #163 Reviewer: Codex gpt-6.1-sol in the existing coordinator session, separate from the implementation session. I did not author or modify the reviewed source. No new reviewer agent, delegate or review-service retry was started. Reason for this review route: the Codex GitHub code-review quota is exhausted, as recorded in #163 (comment) and #163 (comment). This is a separately documented independent source review, not a claim that the failed service review completed or that a required CI check passed. Reviewed identity:
Scope and assessment:
Independent validation:
Documentation impact: the existing host-maintenance upload guidance remains accurate. jq is already a documented host/validation prerequisite. This successor changes no operator command, public schema or capability contract. The PR's focused-proof and timing statements retain their limits and do not claim a proven cause for the earlier full-run assertion. Configuration-template guidance remains tracked in RandomDevelopment/ci-fleet-config-template#47 and remains pending separate acceptance. Verdict: APPROVED for independent source review at exact head Complete current-source native validation, its exports and scoped cleanup remain required before source acceptance or merge. Earlier failed runs and original-source memory proof retain their identities. This receipt grants no live adoption, restart, storage operation, limit change or application retry. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Concurrent build and image-load uploads can charge enough spool-file cache to kill the socket proxy inside its 128 MiB cgroup. Synchronize disk-spool writes and release cached pages in 4 MiB windows while writing and forwarding. Refuse tmpfs/ramfs before dispatch. Preserve the 1 GiB body cap, two upload slots, memory limit, source checks, maintenance locks and uncertainty markers.
Explicit spool read/write methods prevent optimized file copies from bypassing cache release. The memory fixture now unwinds through cleanup on SIGTERM and attempts removal even if Docker log collection fails. Installer recovery reads its five capability flags once through the existing jq prerequisite, while preserving schema, helper, type, mode, exact-key and digest checks. Failed retry waits include the child output; all wait and suite budgets remain unchanged.
Validation passed on exact head
7d08ab3df8d4c3f274e5f8da6bf36e4891819fd5, base49da9d62dfa7527f569e0855b4fb877f6f8c7aed, treea11bbea773b20f0e6d08574c0038275a7460f4ee:Official archive SHA256
a40dfd1cefc0b28c86ff9ec8ad1ec5c9ad08cbf0e6c99b942380d3acdf801389; report SHA2561832b840c392af1878ded1fdfc34fb4d5730c95af67aa37fb88898590928e2c1.Independent manual source review approved this exact head without actionable source or documentation findings. The separate existing coordinator did not author or modify the implementation. It reviewed the complete successor delta, verified unchanged prior-reviewed inputs and independently passed the three focused recovery/guard tests. Codex service quota and Bugbot were unavailable; neither supplied approval. The earlier SIGTERM finding remains resolved.
The original 21ed memory proof retains its own source stamp. Failed run 41564610251 and both 22db attempts of 41568942095 remain retained with their complete available results and cleanup evidence. They are not relabeled as successful acceptance.
Documentation impact:
docs/HOST-MAINTENANCE.mdexplains disk backing, file-cache charges and refusal behavior. jq is already a documented prerequisite. No public schema, capability, desired-state, initializer or operator-command change. Standalone-template guidance remains tracked in RandomDevelopment/ci-fleet-config-template#47 for separate acceptance.Producer, driver, executor and live-pin bytes remain unchanged. Source acceptance does not publish a managed runtime or authorize live adoption, restarts, storage/capacity changes, marker/hold clearing or application retry. No release tag was created.