Repository navigation
fix(approval): recognize versioned Codex review receipts - #149
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Nickfost
marked this pull request as draft
October 24, 2026 20:14
Nickfost
marked this pull request as ready for review
October 24, 2026 20:14
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuration approval rejects the provider's exact v1 receipt header, several verified current opening variants, and completed summaries triggered by marking a draft ready. A genuine clean review can therefore fail approval despite an unchanged head and trusted reviewer identity.
Recognize the exact optional
<!-- codex-review-receipt:v1 -->header, theDraft marked readytrigger and the finite documented set of verified opening variants. Preserve legacy receipt formats, both capture groups, footer grammar, exact commit resolution and numeric reviewer identity. Unknown versions, arbitrary prose, warnings, null finding flags, stale or edited receipts, later conflicting requests, deletions and unresolved review threads remain rejected. A dashboard alone still cannot approve a configuration.Validation: all 48 approval regressions passed without skips. The six additional unedited provider bodies were checked against their independently captured hashes. Python syntax, documentation links, whitespace, commit format and committed-tree credential scanning passed. Initial exact-source review passed for the earlier implementation; a new independent final-head review and full hosted validation remain required for this final set.
Documentation:
docs/CONFIGURATION-APPROVAL.mdlists the exact supported grammar and retained rejection behavior. Standalone-template code/schema need no change; matching operator guidance is tracked in RandomDevelopment/ci-fleet-config-template#42. Runtime selection, images, private configuration and host activation remain separate.