Repository navigation
fix(controller): wait for overlapping runner removal - #145
Merged
Merged
Conversation
Wait up to 30 seconds for Docker to confirm removal when completion and exit cleanup overlap. Keep unrelated Docker failures visible and cover listener batch continuation, missing containers, cancellation and failed waits. Fixes #143
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When job completion overlaps the runner exit watcher, Docker can report that container removal is already in progress. That error currently aborts the scale-set listener and restarts the controller.
Wait up to 30 seconds for Docker's
removedcondition after this specific conflict. An absent container also succeeds. Other conflicts, Docker failures, failed wait responses, cancellation and timeout remain errors.Validation:
go test -race -count=1 -timeout=3m ./....go vet, controller binary build, formatting, exact-commit secret scan, commit/title policy and documentation links passed.Documentation impact: updates
docs/ARCHITECTURE.mdwith bounded overlapping-removal behavior and failure handling. No historical release notes change.Template assessment: no standalone or embedded template change is needed. This internal controller cleanup fix changes no schema, desired-state field, initializer, capability evidence or operator adoption procedure. Engine promotion and live-host acceptance remain separate.
Fixes #143.