fix(ios,android): resync visual state after ancestor display:none removal#5
Merged
Merged
Conversation
…oval Fabric maps ancestor `display: 'none'` to hidden/visibility changes that bypass existing didMoveToWindow/onAttachedToWindow hooks, leaving GleamView stuck in the wrong visual state when the ancestor becomes visible again. - iOS: KVO observer on `self.hidden` detects YES→NO transitions and resyncs - Android: `onVisibilityChanged` override detects VISIBLE transitions and resyncs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
self.hiddento detectYES→NOtransitions (ancestordisplay: 'none'removal) and resync shimmer/content stateonVisibilityChangedto detectVISIBLEtransitions and resync shimmer/content stateContext
Fabric maps ancestor
display: 'none'toUIView.hidden=YES(iOS) /View.setVisibility(INVISIBLE)(Android). These bypass existingdidMoveToWindow/onAttachedToWindowhooks, leaving GleamView stuck in the wrong visual state when the ancestor becomes visible again.Files changed
ios/GleamView.mmobserveValueForKeyPath:handlerandroid/.../GleamView.ktonVisibilityChanged()overridepackage.jsonCHANGELOG.mdTest plan
display: 'none'loading={true}, hide parent, setloading={false}, unhide parent → content visible, no stuck shimmeryarn test— 88 tests pass,yarn typecheck+yarn lintclean