fix(ios): sync visual state in layoutSubviews after display:none#3
Merged
Merged
Conversation
When a GleamView receives loading transitions while its parent has display: 'none', the tick-driven transition may not complete (zero bounds / no window). On re-display, layoutSubviews fires but only handled the loading=YES case — leaving children at alpha 0 and the shimmer layer visible. Add an else-if branch that forces the correct idle state (children alpha 1, shimmer removed, clock stopped) when not loading and no transition is in progress. Each operation is a no-op if state is already correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadingtransitions occur while parent hasdisplay: 'none'else if (!_isTransitioning)branch inlayoutSubviewsto force correct idle state (children alpha 1, shimmer removed, clock stopped) when_loading=NORepro scenario
loading=false)display: 'none'(e.g. lock screen)loadingcyclesfalse → true → false(e.g. React Query cache invalidation)display: 'none'removed →layoutSubviewsfires but only handled_loading=YES→ children stuck at alpha 0Test plan
display: 'none'loadingwhile hidden, verify content appears on re-display🤖 Generated with Claude Code