Centered dragged cards horizontally by replacing images with text icons.#25
Open
Querp wants to merge 1 commit intoRagnar-Oock:masterfrom
Open
Centered dragged cards horizontally by replacing images with text icons.#25Querp wants to merge 1 commit intoRagnar-Oock:masterfrom
Querp wants to merge 1 commit intoRagnar-Oock:masterfrom
Conversation
Ragnar-Oock
requested changes
Dec 29, 2025
Comment on lines
+74
to
+76
| <span v-if="dragged?.type === 'emoji'" class="emoji"> | ||
| {{ dragged.char }} | ||
| </span> |
Owner
There was a problem hiding this comment.
adding support for emoji directly is a good idea, but you should keep the existing image based code too so we can transition back to it when we add actual preview images for each card.
So keep that new span but restore the old img tag you removed
Comment on lines
+17
to
+18
| width: number, | ||
| height: number, |
Owner
There was a problem hiding this comment.
I'm not sure it's a good idea to give control on the size when using an emoji as an preview, for the image it makes sense because we need to be able to use low res images (displayed bigger than they are) and also know the image size to center it on the cursor without loading the image to check its intrinsic size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that some dragged cards are off-center.
You turn the icons into images.
I used the icons instead.
This PR is merely for practice, as I assume you will want to keep the setup for images.