Repository navigation
docs(bench): compare against the common ways to keep Node.js responsive - #6
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark only compared against loops that don't yield, which no strategy can beat on total time. It now runs the same job with the fixes people actually reach for:
awaiton every row, and async'seachSeries, all of which still freeze;setTimeout(0)andsetImmediateafter every row, which stay responsive but take 27x and 1.4x as long;setImmediateevery 500 rows, which freezes for 254 ms on the slow rows.time-sliced finishes within 3% of the plain loop and its longest freeze is 11 ms.
The benchmark is split into workload, strategies, measurement and runner files, and has a warm-up pass.
npm run bench -- --markdownprints the README table.asyncis an exact-version dev dependency, used only by the benchmark.