Repository navigation
fix: edge checks back, and verify through a symlink - #26
Merged
Merged
Conversation
…othing again The type-aware cleanup took out two checks at the library's edges that its types rule out but a JavaScript caller or an injected FetchLike can still reach: trackFromMetadata(null) returns null again, and getBinary reads a response without headers as no content type. Both are disabled on their line with the reason, as the player library does. verify runs when its path comes through a symlink, which before made it skip every step and exit 0; a test runs it both ways.
…t type Pins the restored guard: without it, an injected FetchLike that answers without headers, or with headers that have no get(), throws again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #25, from its council review.
trackFromMetadata(null)from a JavaScript caller returnsnullagain instead of throwing.getBinaryreads a Response-like answer from an injectedFetchLikethat has noheadersas having no content type. Both checks are kept with anoxlint-disable-next-line … -- reason, as RNAP does for checks of caller input. Tests cover both (a FetchLike answer withoutheaders, or with headers that lackget).verifythrough a symlink. The "run as a script" check comparedimport.meta.urlwith the unresolvedargv[1]. Started through a symlinked path,verifyran nothing and exited 0, a silent pass for what is now the only CI gate. It now compares real paths, and a subprocess test runs it directly and through a symlink. The test fails with the old check.Verification
pnpm run check:ci: all 9 steps pass (tooling tests 15, 248 unit tests)Council review
Covers #25 (merged before review) and this follow-up.
Rounds: 2
Gemini could not be reached (OpenCode Go subscription required); no other provider stood in. Nothing was blocking in either round; both reviewers are satisfied for merge. This PR is round 1's findings for the API; the getBinary test is round 2's.