RefID to support garbage collection of objects#100
Draft
RT-nilPointer wants to merge 6 commits intomasterfrom
Draft
RefID to support garbage collection of objects#100RT-nilPointer wants to merge 6 commits intomasterfrom
RT-nilPointer wants to merge 6 commits intomasterfrom
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 67.78% 68.01% +0.22%
==========================================
Files 15 16 +1
Lines 950 991 +41
==========================================
+ Hits 644 674 +30
- Misses 201 206 +5
- Partials 105 111 +6
Continue to review full report at Codecov.
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 67.78% 68.01% +0.22%
==========================================
Files 15 16 +1
Lines 950 991 +41
==========================================
+ Hits 644 674 +30
- Misses 201 206 +5
- Partials 105 111 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Keeps track of RefIDs for the detection of objects and updating of buckets.
The root of RefIDs is generated from a local secret, a malicious user with access to this secret can cause data loss.
Motivation and Context
Support the missing deletion of content on the backend.
How to test this PR?
Need the latest TemporalX backend with RefID support