You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
修复 issue #11596:tiny 版本 rt_vsnprintf 在格式化 %lld/%lli 时,把 ll qualifier 与 l qualifier 合并到 long 路径处理,导致 long long 数值被错误截断或符号判断错误,例如 INT64_MAX 输出为 -1。
你的解决方案是什么 (what is your solution)
在 rt_vsnprintf_tiny.c 中将 L(内部用于表示 ll)和 l 的有符号处理拆开:ll 按 long long 取参并按 64 位符号范围处理,l 继续保持 long 路径。同步补充 rt_sprintf long long 边界值回归用例,覆盖 INT32_MIN、UINT32_MAX、INT64_MIN、INT64_MAX。
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!
为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).
设置需排除的文件/目录(目录请以"/"结尾)
Set files/directories to exclude (directories should end with "/")
将目标分支设置为 \ Set the target branch to:fix/klibc-vsnprintf-long-long
设置PR number为 \ Set the PR number to:11600
等待工作流完成 | Wait for the workflow to complete
格式化后的代码将自动推送至你的分支。
The formatted code will be automatically pushed to your branch.
完成后,提交将自动更新至 fix/klibc-vsnprintf-long-long 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix/klibc-vsnprintf-long-long branch automatically, and the related Pull Request will be updated.
如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述(PR description)
[
为什么提交这份PR (why to submit this PR)
修复 issue #11596:tiny 版本
rt_vsnprintf在格式化%lld/%lli时,把llqualifier 与lqualifier 合并到long路径处理,导致 long long 数值被错误截断或符号判断错误,例如INT64_MAX输出为-1。你的解决方案是什么 (what is your solution)
在
rt_vsnprintf_tiny.c中将L(内部用于表示ll)和l的有符号处理拆开:ll按long long取参并按 64 位符号范围处理,l继续保持long路径。同步补充rt_sprintflong long 边界值回归用例,覆盖INT32_MIN、UINT32_MAX、INT64_MIN、INT64_MAX。请提供验证的bsp和config (provide the config and bsp)
BSP: bsp/qemu-vexpress-a9
.config: CONFIG_RT_KLIBC_USING_VSNPRINTF_LONGLONG=y,未启用 CONFIG_RT_KLIBC_USING_VSNPRINTF_STANDARD,使用 tiny 版本验证
action: 本地环境缺少可用交叉编译工具链,未触发 action;已执行
git diff --check]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I have considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up