-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[docs][libcpu][arm][cortex-a] add comment for gic.c #11128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
60c3df6 to
ef888a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive English documentation comments to the GIC (Generic Interrupt Controller) driver for ARM Cortex-A processors. The changes improve code readability by documenting register macros with official ARM specification names and adding detailed function documentation with parameter descriptions, return values, and usage notes.
Key Changes:
- Added ARM GIC register names as inline comments for all macro definitions (GICC_* and GICD_*)
- Added complete function documentation blocks for all 25+ public API functions
- Removed an inaccurate comment stating ARM_GIC_MAX_NR represents the number of CPU cores
| * @brief Enables the forwarding of the corresponding interrupt | ||
| * | ||
| * @param index GIC controller index | ||
| * @param irq The actual interrupt number(with offset) |
Copilot
AI
Jan 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space between "number" and "(with". Should be "number (with offset)" for consistency.
"number" 和 "(with" 之间缺少空格。应为 "number (with offset)" 以保持一致性。
| * @brief clears the pending state of the interrupt | ||
| * | ||
| * @param index GIC controller index | ||
| * @param irq The actual interrupt number(with offset) |
Copilot
AI
Jan 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space between "number" and "(with". Should be "number (with offset)" for consistency.
"number" 和 "(with" 之间缺少空格。应为 "number (with offset)" 以保持一致性。
| * @brief Identifies whether the corresponding interrupt is edge-triggered or level-sensitive | ||
| * | ||
| * @param index GIC controller index | ||
| * @param irq The actual interrupt number(with offset) |
Copilot
AI
Jan 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space between "number" and "(with". Should be "number (with offset)" for consistency.
"number" 和 "(with" 之间缺少空格。应为 "number (with offset)" 以保持一致性。
| * @brief Identifies whether the interrupt is pending | ||
| * | ||
| * @param index GIC controller index | ||
| * @param irq The actual interrupt number(with offset) |
Copilot
AI
Jan 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space between "number" and "(with". Should be "number (with offset)" for consistency.
"number" 和 "(with" 之间缺少空格。应为 "number (with offset)" 以保持一致性。
| * @brief Get the priority for the specific interrupt | ||
| * | ||
| * @param index GIC controller index | ||
| * @param irq The actual interrupt number(with offset) |
Copilot
AI
Jan 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space between "number" and "(with". Should be "number (with offset)" for consistency.
"number" 和 "(with" 之间缺少空格。应为 "number (with offset)" 以保持一致性。
|
@laidene 还请压缩成一个commit提交谢谢 |
efc9696 to
04de1a7
Compare
已压缩为一个commit |
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
添加gic.c的注释,我认为可以辅助理解代码。
你的解决方案是什么 (what is your solution)
1 在对GIC寄存器宏定义处添加文档寄存器名称。
2 补全函数注释。
3 删除部分注释。
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up改动说明
1 在对GIC寄存器读写的宏定义处添加寄存器名称
参照
ARM ® Generic Interrupt Controller Architecture Specification(Architecture version 2.0),给出寄存器在文档中的关键字,便于查看文档。2 补全函数注释
3 删除部分注释
我认为 ARM_GIC_MAX_NR 不是核心数,多核smp也可以只有1个GIC控制器。
我认为注释不准确所以删除。
测试
纯注释改动
