Conversation
Haidery
commented
Jan 4, 2016
- Basically we gave user ability to exclude area from the color plate. This is useful to exclude any dark colors in centre or if you want your color plate to host a control inside it.
Owner
|
I tried to test this but can't get it to work. Could you explain usage or update the sample app with an obvious example? Also you made some changes like setting the default color to blue and making the selection view size smaller. Unless these are necessary for this patch they should be reverted. Last, it looks like you just updated one of the unit tests. If this truly is changing the functionality then I would suggest creating tests for this feature separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.