docs(rocsparse): move handle_create/destroy changelog entries to 5.0.0 - #10269
Open
amontoison wants to merge 1 commit into
Open
docs(rocsparse): move handle_create/destroy changelog entries to 5.0.0#10269amontoison wants to merge 1 commit into
amontoison wants to merge 1 commit into
Conversation
rocsparse_handle_create and rocsparse_handle_destroy were listed under the "rocSPARSE 4.6.0" section, but they were introduced in the 5.0.0 development cycle (commit 458dd38, PR ROCm#8083, 2026-07-17, at project VERSION 5.0.0). PR ROCm#8083 added the entries under the wrong version heading. Move them to the (Unreleased) rocSPARSE 5.0.0 "Added" section. The other 4.6.0 entries pre-date the monorepo consolidation and are unchanged.
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
rocsparse_handle_createandrocsparse_handle_destroywere listed under therocSPARSE 4.6.0section ofCHANGELOG.md, but they were introduced in the 5.0.0 development cycle. This moves the two entries to the (Unreleased)rocSPARSE 5.0.0"Added" section.Why
The routines first appeared in commit
458dd380(PR #8083, 2026-07-17), when the project version was already 5.0.0, that PR added the changelog lines under the wrong version heading.I discovered it in #10262 when I wanted to list when the feature guards were added in
rocSPARSE.It requires a confirmation of Kim (@kliegeois).