Skip to content

feat(rocke): resolve rocKE targets through HIP - #10248

Draft
tenpercent wants to merge 1 commit into
developfrom
users/mpodkory/rocke/aick-1849
Draft

feat(rocke): resolve rocKE targets through HIP#10248
tenpercent wants to merge 1 commit into
developfrom
users/mpodkory/rocke/aick-1849

Conversation

@tenpercent

Copy link
Copy Markdown
Contributor

Summary

  • add an optional HIP runtime API for resolving the current device architecture with structured errors
  • resolve an omitted unified-attention target through HIP while keeping explicit targets authoritative
  • leave HIP_VISIBLE_DEVICES interpretation to HIP and avoid process-wide device or architecture caching
  • add host-only coverage through an injected HIP function table and leave Python follow-up TODOs

Test plan

  • build rocke_core, rocke_hip_target_resolution, and rocke_tiled_attention_2d_reentrancy
  • run focused CTest coverage for HIP target resolution and attention reentrancy
  • build the rocke_engine pybind module
  • verify attention byte identity with llvm20, llvm22, and llvm23
  • run PR-range pre-commit hooks; all applicable hooks pass except the existing whole-file CMake lint baseline
  • run a physical-GPU runtime query; this host has no ROCm-capable device, and the error path plus injected HIP behavior are covered by host tests

ISSUE ID : AICK-1849

@github-actions github-actions Bot added project: hip-kernel-provider rocke-lib: attention Touches rocKE library attention/FMHA kernels labels Jul 31, 2026
@therock-pr-bot

therock-pr-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled
🤖 therock-pr-bot ✅ Pass

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@tenpercent
tenpercent force-pushed the users/mpodkory/rocke/aick-1849 branch from 961b996 to 4e81afa Compare July 31, 2026 21:49
@tenpercent tenpercent changed the title feat(hip-kernel-provider): resolve rocKE targets through HIP feat(rocke): resolve rocKE targets through HIP Jul 31, 2026
@tenpercent
tenpercent force-pushed the users/mpodkory/rocke/aick-1849 branch 2 times, most recently from 42ed787 to b2280d1 Compare July 31, 2026 22:01
@tenpercent
tenpercent force-pushed the users/mpodkory/rocke/aick-1849 branch from b2280d1 to 46e2dbd Compare July 31, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant