Skip to content

fix(CK): Forward port convolutions update from standalone repo - #10245

Draft
geyyer wants to merge 2 commits into
developfrom
users/rogeyyer/ck/aick-1818
Draft

fix(CK): Forward port convolutions update from standalone repo#10245
geyyer wants to merge 2 commits into
developfrom
users/rogeyyer/ck/aick-1818

Conversation

@geyyer

@geyyer geyyer commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Motivation

Forward-port grouped-conv-fwd perf-regression fix (im2col GEMM-size 2GB check) to rocm-libraries mainline

Technical Details

Port this commit ROCm/composable_kernel@248f155#diff-d921922979d6cfc604769c3bc231107ae574375875ecce04bcb1065d43a5ce2e

Introduced by a mainline change for grouped-conv large-tensor / global-load-store CK enablement, which added a LargeTensors template flag to GridwiseGemmMultiD_xdl_cshuffle_v3 and reworked its CheckValidity, but did not exempt the convolution im2col-view path from the pre-existing logical-GEMM-size 2GB check

Test Plan

Regular CI

Test Result

CI should pass

Submission Checklist

JIRA ID : AICK-1818

@therock-pr-bot

therock-pr-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/composablekernel/include/ck/tensor_operation/gpu/device/impl/device_grouped_conv_fwd_multiple_abd_xdl_cshuffle_v3.hpp, projects/composablekernel/include/ck/tensor_operation/gpu/grid/gridwise_gemm_xdl_cshuffle_v3_multi_d.hpp; no test file found
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled
🤖 therock-pr-bot ✅ Pass

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant