This repository was archived by the owner on Jun 23, 2026. It is now read-only.
Add --experiments option in CLI - #23
Merged
Merged
Conversation
cfallows-amd
suggested changes
Oct 28, 2025
cfallows-amd
left a comment
cfallows-amd
left a comment
Collaborator
There was a problem hiding this comment.
Minor change request for naming convention.
Please confirm running roofline binary shows the specified num experiments in the stats in terminal output when adding -e. Thanks
Contributor
Author
Roofline shows the specified num experiments both with -e and --experiments. |
cfallows-amd
approved these changes
Nov 3, 2025
cfallows-amd
left a comment
cfallows-amd
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for confirming testing. New roofline bins will be rebuilt in a separate PR for rocprofiler-compute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Number of experiments (-e or --experiments) option is present in help but not usable.
Technical Details
Add -e processing
Test Plan
Test Result
Submission Checklist