Conversation
…tools warnings The hyphenated name is not a valid Python identifier, preventing setuptools from treating the bundled C++/HIP source directories as implicit namespace packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_jit_sources/to_jit-sources/so setuptools no longer treats bundled C++/HIP source directories as implicit namespace packagesumbp_masterandspdk_proxybuild artifacts to.gitignoreDetails
Since PR #182 introduced
_copy_jit_sources(), everypip install -eproduces dozens of "Package would be ignored" warnings from setuptools. The root cause is that_jit_sourcesis a valid Python identifier, so Python 3.3+ namespace package rules make every subdirectory appear importable. Using a hyphenated name (_jit-sources) breaksstr.isidentifier(), which is exactly what setuptools checks.Test plan
BUILD_UMBP=ON BUILD_TESTS=ON pip install -e . --no-build-isolation -vproduces no "Package would be ignored" warningspython -c "from mori.jit.config import get_mori_source_root; print(get_mori_source_root())"still resolves correctly