[openmp] Fix device omp_lib.mod build to use host flang-rt modules#3094
Open
skganesan008 wants to merge 1 commit into
Open
[openmp] Fix device omp_lib.mod build to use host flang-rt modules#3094skganesan008 wants to merge 1 commit into
skganesan008 wants to merge 1 commit into
Conversation
|
PSDB Build Link: http://mlse-bdc-20dd129:8065/#/builders/10/builds/580 |
Device runtimes sub-builds configure with LLVM_ENABLE_RUNTIMES=openmp only, so omp_lib.F90 for amdgcn/nvptx can compile before iso_c_binding.mod exists. Point libomp-mod at the host flang-rt module directory and order device runtimes builds after flang-rt-mod.
6fb0953 to
c87df6e
Compare
|
PSDB Build Link: http://mlse-bdc-20dd129:8065/#/builders/10/builds/581 |
Collaborator
Author
|
llvm#188495 seems to be addressing the same/similar problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Device runtimes sub-builds configure with LLVM_ENABLE_RUNTIMES=openmp only, so omp_lib.F90 for amdgcn/nvptx can compile before iso_c_binding.mod exists. Point libomp-mod at the host flang-rt module directory and order device runtimes builds after flang-rt-mod.