[CI][Security] ROCM-26563: enforce HTTPS verification in PSDB trigger…#3082
Closed
vkallesh wants to merge 1 commit into
Closed
[CI][Security] ROCM-26563: enforce HTTPS verification in PSDB trigger…#3082vkallesh wants to merge 1 commit into
vkallesh wants to merge 1 commit into
Conversation
… workflow Remove PYTHONHTTPSVERIFY=0 from the cancel_previous_build.py and jenkins_api.py docker exec invocations in PSDB-amd-staging.yml. This flag globally disabled Python TLS certificate verification for all outbound HTTPS in those processes (Jenkins API and GitHub API calls), exposing credentials (CI_JENKINS_TOKEN, GITHUB_PAT) to man-in-the-middle attacks. The Jenkins endpoint (compiler-ci.amd.com) presents a valid, publicly-trusted DigiCert certificate, so verification can be safely enforced. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
Raised new PR #3086, so closing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the issue "ROCM-26563 — PSDB Jenkins trigger: HTTPS verification disabled"
End-to-end flow: A PR to amd-staging runs the GitHub Actions workflow PSDB-amd-staging.yml on a self-hosted runner. It pulls an internal Docker image (JENKINS_TRIGGER_DOCKER_IMAGE) and runs two Python scripts inside it — cancel_previous_build.py and jenkins_api.py — which call the Jenkins server and the GitHub API to cancel stale builds and trigger the PSDB pipeline.
Issue: Both scripts were launched with PYTHONHTTPSVERIFY=0, which globally disables TLS certificate verification. This left the Jenkins and GitHub calls open to man-in-the-middle attacks and credential interception (CI_JENKINS_TOKEN, GitHub PAT). The flag is unnecessary — Jenkins presents a valid public DigiCert certificate.