[SPIRV][CI] Add ROCm Examples for Linux#3048
Open
idubinov wants to merge 8 commits into
Open
Conversation
idubinov
commented
Jun 24, 2026
idubinov
commented
- Build runtime libs, required by ROCm Examples
- Add test for ROCm Examples into current SPIRV CI pipeline
- Update upload/download action version due to deprecation
idubinov
added
ci:skip
aobolensk
reviewed
Jun 26, 2026
| - name: Install build deps for runtime build | ||
| run: | | ||
| dnf install -y --setopt=install_weak_deps=False \ | ||
| numactl-devel elfutils-libelf-devel libdrm-devel || true |
There was a problem hiding this comment.
Can we get rid of || true here and below?
| echo "=== staging/lib after install (comgr files) ===" | ||
| ls -la staging/lib/libamd_comgr* 2>&1 || true | ||
| - name: Checkout rocm-systems (pinned) |
There was a problem hiding this comment.
What do you mean by "pinned" here? If actions/checkout version then I think this detail can be omitted
| ls -la staging/lib/libamd_comgr* 2>&1 || true | ||
| - name: Checkout rocm-systems (pinned) | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 |
| -DCLR_BUILD_HIP=ON \ | ||
| -DROCM_KPACK_ENABLED=OFF \ | ||
| -DHIP_ENABLE_ROCPROFILER_REGISTER=OFF \ | ||
| -DHIPCC_BIN_DIR= |
There was a problem hiding this comment.
That looks strange. What is the purpose of setting this to empty value?
| - name: Upload build tree artifact | ||
| uses: actions/upload-artifact@v4 | ||
| uses: actions/upload-artifact@v7 |
There was a problem hiding this comment.
Why this action version is not pinned, but actions/checkout is pinned?
| -DCMAKE_HIP_FLAGS="--rocm-path=$STAGING" \ | ||
| -DCMAKE_HIP_LINK_FLAGS="-L$STAGING/lib -Wl,-rpath,$STAGING/lib" \ | ||
| -DCMAKE_EXE_LINKER_FLAGS="-L$STAGING/lib -Wl,-rpath,$STAGING/lib" | ||
| cmake --build examples-build-Applications -j |
There was a problem hiding this comment.
Please specify amount of jobs for -j flag
Comment on lines
+171
to
+185
| # Create hipconfig script for rocPRIM/hipCUB detection | ||
| - name: Create hipconfig script | ||
| run: | | ||
| mkdir -p staging/bin | ||
| cat > staging/bin/hipconfig << 'EOF' | ||
| #!/bin/bash | ||
| case "$1" in | ||
| --platform) echo "amd" ;; | ||
| --compiler) echo "clang" ;; | ||
| --runtime) echo "rocclr" ;; | ||
| --hipclangpath) echo "$PWD/build/bin" ;; | ||
| *) echo "amd" ;; | ||
| esac | ||
| EOF | ||
| chmod +x staging/bin/hipconfig |
There was a problem hiding this comment.
Where is hipconfig used? The question is why we cannot use existing (?) hipconfig with only specifying custom clang path if it is really needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.