[compiler-rt][AMDGPU] Remove redundant GPU.cmake cache file#3027
Draft
lfmeadow wants to merge 1 commit into
Draft
[compiler-rt][AMDGPU] Remove redundant GPU.cmake cache file#3027lfmeadow wants to merge 1 commit into
lfmeadow wants to merge 1 commit into
Conversation
Superseded by AMDGPU.cmake (upstream llvm#190349); TheRock now references AMDGPU.cmake, so GPU.cmake is unused. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jun 23, 2026
Collaborator
|
[amd-llvm] loading initial cache file /__w/llvm-project/llvm-project/compiler/amd-llvm/llvm/../compiler-rt/cmake/caches/GPU.cmake |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The amdgcn device runtimes cache file
compiler-rt/cmake/caches/GPU.cmakeissuperseded by
AMDGPU.cmake(upstream llvm#190349). UnlikeAMDGPU.cmake,GPU.cmakeleftCOMPILER_RT_BUILD_PROFILE=OFF, so the device profile runtime(
libclang_rt.profile.aforamdgcn-amd-amdhsa) was never built — breaking HIPdevice PGO. This removes the dead file.
Co-dependency
Pairs with ROCm/TheRock#6055, which points the amdgcn runtimes cache at
AMDGPU.cmakeinstead ofGPU.cmake. Land ROCm/TheRock#6055 first so noconsumer references
GPU.cmakebefore this deletion is picked up via a submodulebump.
Test plan
AMDGPU.cmake; confirmlibclang_rt.profile.ais produced and no sanitizer/runtime regressions.