Skip to content

[compiler-rt][AMDGPU] Remove redundant GPU.cmake cache file#3027

Draft
lfmeadow wants to merge 1 commit into
ROCm:amd-stagingfrom
lfmeadow:users/lmeadows/remove-redundant-gpu-cmake
Draft

[compiler-rt][AMDGPU] Remove redundant GPU.cmake cache file#3027
lfmeadow wants to merge 1 commit into
ROCm:amd-stagingfrom
lfmeadow:users/lmeadows/remove-redundant-gpu-cmake

Conversation

@lfmeadow

@lfmeadow lfmeadow commented Jun 23, 2026

Copy link
Copy Markdown

Summary

The amdgcn device runtimes cache file compiler-rt/cmake/caches/GPU.cmake is
superseded by AMDGPU.cmake (upstream llvm#190349). Unlike AMDGPU.cmake,
GPU.cmake left COMPILER_RT_BUILD_PROFILE=OFF, so the device profile runtime
(libclang_rt.profile.a for amdgcn-amd-amdhsa) was never built — breaking HIP
device PGO. This removes the dead file.

Co-dependency

Pairs with ROCm/TheRock#6055, which points the amdgcn runtimes cache at
AMDGPU.cmake instead of GPU.cmake. Land ROCm/TheRock#6055 first so no
consumer references GPU.cmake before this deletion is picked up via a submodule
bump.

Test plan

  • Build amdgcn runtimes via TheRock with AMDGPU.cmake; confirm
    libclang_rt.profile.a is produced and no sanitizer/runtime regressions.

Superseded by AMDGPU.cmake (upstream llvm#190349); TheRock now references
AMDGPU.cmake, so GPU.cmake is unused.

Co-authored-by: Cursor <cursoragent@cursor.com>
@ronlieb

ronlieb commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

[amd-llvm] loading initial cache file /__w/llvm-project/llvm-project/compiler/amd-llvm/llvm/../compiler-rt/cmake/caches/GPU.cmake
[amd-llvm] CMake Error: Error processing file: /__w/llvm-project/llvm-project/compiler/amd-llvm/compiler-rt/cmake/caches/GPU.cmake

@lfmeadow lfmeadow marked this pull request as draft June 23, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants