Skip to content
This repository was archived by the owner on Jun 23, 2026. It is now read-only.

Introduce KMHACKISA environment variable for ISA-level code injection.#1246

Open
whchung wants to merge 1 commit into
clang_tot_upgradefrom
exp-inject-isa
Open

Introduce KMHACKISA environment variable for ISA-level code injection.#1246
whchung wants to merge 1 commit into
clang_tot_upgradefrom
exp-inject-isa

Conversation

@whchung

@whchung whchung commented Aug 20, 2019

Copy link
Copy Markdown
Collaborator

When used with -fno-gpu-rdc, this allows applications to inject ISA into
object files. This flag is used for kernel developers to tweak ISA before an
optimization can be devised in the compiler.

The feature is developed for @asroy and @zjing14 . Need verification from their applications first.

When used with -fno-gpu-rdc, this allows applications to inject ISA into
object files. This flag is used for kernel developers to tweak ISA before an
optimization can be devised in the compiler.
@whchung whchung requested review from aaronenyeshi and scchan August 20, 2019 21:34

@scchan scchan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should work

@whchung whchung changed the title [DO NOT MERGE] Introduce KMHACKISA environment variable for ISA-level code injection. Introduce KMHACKISA environment variable for ISA-level code injection. Aug 21, 2019
@whchung

whchung commented Aug 21, 2019

Copy link
Copy Markdown
Collaborator Author

@scchan , @asroy and @zjing14 both could apply the patch onto their projects and do ISA-level tweaking now. Removing [DO NOT MERGE] tag now.

@whchung whchung requested a review from scchan August 23, 2019 15:38
@whchung

whchung commented Aug 29, 2019

Copy link
Copy Markdown
Collaborator Author

with this PR you are able to inject additional or replace ISA coming out from the compiler.

@whchung

whchung commented Aug 29, 2019

Copy link
Copy Markdown
Collaborator Author

@scchan This feature is gradually getting picked up by kernel developers in MIOpen team. Wondering could you give this PR another go? Thanks.

@scchan

scchan commented Aug 29, 2019

Copy link
Copy Markdown
Collaborator

@whchung I'd like to get PR1245 first if possible since it's higher priority. This PR will probably have be updated to adapt to those changes.

@aaronenyeshi aaronenyeshi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing old prs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants