Repository navigation
fix(preflight): score an empty node set as an error - #694
Merged
Merged
Conversation
A crash backfill records status SKIPPED without the skipped flag, and summarisers that ignored that status scored zero nodes as a pass.
hnimra-amd
requested review from
anujmittal-amd,
cijohnson and
frepaul
as code owners
October 30, 2026 18:18
cijohnson
approved these changes
Oct 30, 2026
Security scan found no critical or high findings on lines changed by this pull request1 medium, low, or unrated finding(s) are not listed; the scan run has them. View the security scan run for complete reports. “New” means the finding is located in a changed file on an added or modified line; it is not a base-versus-head findings delta. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release/cvs-0.3.0.status: SKIPPEDas skipped even when theskippedflag is absent, so a crash backfill is no longer scored as PASS 0/0.https://amd-hub.atlassian.net/browse/AIMVT-436
Test
Checked the report summarizer on
release/cvs-0.3.0(6a43049) and on the same fix (c8de366, now this cherry-pick of8a38dde8) with an empty node set.On
release/cvs-0.3.0the empty result is scored as a pass, and the report stays PASS:On this fix those same inputs are ERROR (
tested no nodes), and a status-only SKIPPED backfill stays SKIPPED. The empty-node unit tests pass (8/8). An empty SSH reachability result fails the preflight report.A live
preflight_checksrun on two reachable nodes does not hit this path. Bothrelease/cvs-0.3.0and the fix finished PASS, 72 passed and 8 skipped, with SSH and node smoke at 2/2. Both logs also containNode Smoke Tier 3 PASS on 0/2 nodesafter a Tier 3 torchrun abort; the summary still records Tier 3 as 2/2. That line is unchanged by this fix.