Skip to content

CI: add a16w16 GEMM to op tuning workflow#3605

Draft
gyohuangxin wants to merge 1 commit into
mainfrom
ci/add-a16w16-op-tune
Draft

CI: add a16w16 GEMM to op tuning workflow#3605
gyohuangxin wants to merge 1 commit into
mainfrom
ci/add-a16w16-op-tune

Conversation

@gyohuangxin
Copy link
Copy Markdown
Member

Summary

  • Add the gemm_a16w16 job to the operator tuning script so bf16 GEMM tuning can refresh bf16_tuned_gemm.csv from bf16_untuned_gemm.csv.
  • Include gemm_a16w16 in the manual Operators Tuning workflow shape examples.

Test plan

  • bash -n .github/scripts/op_tune.sh
  • git diff --check

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2026

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:triton-300x Run an additional Triton test job on MI300X in PRs; main branch always runs both MI35X and MI300X
ci:sglang SGLang integration tests: DeepSeek-R1-MXFP4 accuracy, Qwen 3.5 accuracy
ci:atom ATOM benchmark: DeepSeek-R1-0528, GPT-OSS-120B
ci:atom_full ATOM accuracy suite for PR and main models from ATOM models_accuracy.json
ci:vllm vLLM benchmark: GPT-OSS-120B, DeepSeek-R1-0528, Kimi-K2.5
ci:all All standard extended tests (excludes ci:atom_full)

Only add ci:atom_full for FlyDSL or Triton upgrades.
Add labels via the sidebar or gh pr edit 3605 --add-label <label>

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the manual “Operators Tuning” workflow to include the BF16 GEMM tuner (gemm_a16w16) so the workflow can refresh aiter/configs/bf16_tuned_gemm.csv from aiter/configs/bf16_untuned_gemm.csv via the existing op_tune.sh orchestration.

Changes:

  • Add a new gemm_a16w16 entry to .github/scripts/op_tune.sh so it can be selected/run like other tuning shapes.
  • Update the workflow-dispatch shapes input description to include gemm_a16w16 in the examples.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/operators-tuning.yaml Updates the manual workflow input help text to include gemm_a16w16 among example shapes.
.github/scripts/op_tune.sh Adds gemm_a16w16 to the tuning job list, wiring it to the existing BF16 GEMM untuned/tuned CSV paths.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gyohuangxin gyohuangxin marked this pull request as draft June 8, 2026 08:39
declare -a tune_jobs=(
"ck_batched_gemm_a8w8:csrc/ck_batched_gemm_a8w8:op_tests/test_batched_gemm_a8w8.py:python3 csrc/ck_batched_gemm_a8w8/batched_gemm_a8w8_tune.py -i aiter/configs/a8w8_untuned_batched_gemm.csv -o aiter/configs/a8w8_tuned_batched_gemm.csv"
"ck_batched_gemm_bf16:csrc/ck_batched_gemm_bf16:op_tests/test_batched_gemm_bf16.py:python3 csrc/ck_batched_gemm_bf16/batched_gemm_bf16_tune.py -i aiter/configs/bf16_untuned_batched_gemm.csv -o aiter/configs/bf16_tuned_batched_gemm.csv"
"gemm_a16w16:csrc/gemm_a16w16:op_tests/test_gemm_a16w16.py:python3 csrc/gemm_a16w16/gemm_a16w16_tune.py -i aiter/configs/bf16_untuned_gemm.csv -o aiter/configs/bf16_tuned_gemm.csv"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use this, python3 csrc/gemm_a16w16/gemm_tuner.py -i aiter/configs/bf16_untuned_gemm.csv -o aiter/configs/bf16_tuned_gemm.csv. Both are supported, but this can support tune with hipblaslt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants