Skip to content

fix deepgemm_fp8_paged_mqa_logits kernel input parameter mismatch issue#3604

Open
lirui927 wants to merge 1 commit into
mainfrom
lirui/fix
Open

fix deepgemm_fp8_paged_mqa_logits kernel input parameter mismatch issue#3604
lirui927 wants to merge 1 commit into
mainfrom
lirui/fix

Conversation

@lirui927
Copy link
Copy Markdown

@lirui927 lirui927 commented Jun 8, 2026

Motivation

fix deepgemm_fp8_paged_mqa_logits kernel input parameter mismatch issue(caused by d863d2f)

Technical Details

add parameter of IS_GFX1250 when run kernel

Test Plan

Accuracy test

Test Result

model_path=/shared/data/amd_int/models/deepseek-ai/DeepSeek-V3.2 lm_eval --model local-completions \ --model_args model=$model_path,base_url=http://localhost:8001/v1/completions,num_concurrent=65,max_retries=1,tokenized_requests=False,trust_remote_code=True \ --tasks gsm8k \ --num_fewshot 20

image

Submission Checklist

@lirui927 lirui927 requested a review from a team June 8, 2026 07:59
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2026

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:triton-300x Run an additional Triton test job on MI300X in PRs; main branch always runs both MI35X and MI300X
ci:sglang SGLang integration tests: DeepSeek-R1-MXFP4 accuracy, Qwen 3.5 accuracy
ci:atom ATOM benchmark: DeepSeek-R1-0528, GPT-OSS-120B
ci:atom_full ATOM accuracy suite for PR and main models from ATOM models_accuracy.json
ci:vllm vLLM benchmark: GPT-OSS-120B, DeepSeek-R1-0528, Kimi-K2.5
ci:all All standard extended tests (excludes ci:atom_full)

Only add ci:atom_full for FlyDSL or Triton upgrades.
Add labels via the sidebar or gh pr edit 3604 --add-label <label>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants