[TRITON] Fix Assert in Triton fused_kv_cache#3601
Open
leonling-ll wants to merge 1 commit into
Open
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
|
looks good to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assertion in triton kernel
fused_qk_rope_reshape_and_cache:t == tk == tv and t_slot <= tkwould be inconsistant the logic in_fused_qk_rope_reshape_and_cache_kernel.In which pid could be greater than TxQH, while the assertion assume the launch grid is smaller or equal to TxQH (
n_pid = t * qh + (t_slot - t) * kh)This makes CI failing: https://github.com/ROCm/ATOM/actions/runs/27060334232/job/79872120485#step:22:537
This PR aims to fix it and fix some typo.