Integrate DS R1 GroupedTopk + Sigmoid Routing Into DS Routing#3522
Merged
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
3ecd064 to
63bca7d
Compare
k50112113
reviewed
Jun 4, 2026
k50112113
previously requested changes
Jun 4, 2026
Contributor
k50112113
left a comment
There was a problem hiding this comment.
Can you also help check if the _grouped_topk kernel you added here is functionally the same as the one on the HIP side? no need to add unit test
…atom. small change to import in routing
740a970 to
682213e
Compare
fixed recommended issues, dismissing stale review
lburzawa
approved these changes
Jun 6, 2026
k50112113
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Integrate new GroupedTopk kernel with support for score_mode sigmoid into routing + unified routing function, renamed function to reflect change. For changes done in ROCm/ATOM#1044.
Technical Details
grouped_topk kernel added to topk files, integrated into grouped topk.
Test Plan
Pytest for kernel included in routing pytest file, lm_eval on atom deepseek r1 mxfp4
Test Result
Kernel pytests passing, lm_eval 98% for atom integration for deepseek r1 mxfp4.
Submission Checklist