Validate paged_attention input#3455
Open
JohnNikolay84 wants to merge 2 commits into
Open
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
valarLip
previously approved these changes
Jun 8, 2026
c0621a3 to
33413b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
2 stage HIP kernels for paged attention rely on clients to allocate sufficient memory for scratch buffer between stages and also assume a sertain input shapes. Those assumptions are never validated, if they are not correct the host would just go ahead and dispatch a GPU work which will likely produce a fault if memory is not enough.
Technical Details
Add pipeline validation for input tensors for both pa and pa_v1.
Test Plan
Negative tests when scratch memory is not enough should assert and not produce a page fault.
Test Result
Submission Checklist