Skip to content

Validate paged_attention input#3455

Open
JohnNikolay84 wants to merge 2 commits into
mainfrom
pa_input_vaildation
Open

Validate paged_attention input#3455
JohnNikolay84 wants to merge 2 commits into
mainfrom
pa_input_vaildation

Conversation

@JohnNikolay84
Copy link
Copy Markdown
Contributor

Motivation

2 stage HIP kernels for paged attention rely on clients to allocate sufficient memory for scratch buffer between stages and also assume a sertain input shapes. Those assumptions are never validated, if they are not correct the host would just go ahead and dispatch a GPU work which will likely produce a fault if memory is not enough.

Technical Details

Add pipeline validation for input tensors for both pa and pa_v1.

Test Plan

Negative tests when scratch memory is not enough should assert and not produce a page fault.

Test Result

Submission Checklist

@JohnNikolay84 JohnNikolay84 requested a review from a team June 1, 2026 08:58
@JohnNikolay84 JohnNikolay84 self-assigned this Jun 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:triton-300x Run an additional Triton test job on MI300X in PRs; main branch always runs both MI35X and MI300X
ci:sglang SGLang integration tests: DeepSeek-R1-MXFP4 accuracy, Qwen 3.5 accuracy
ci:atom ATOM benchmark: DeepSeek-R1-0528, GPT-OSS-120B
ci:atom_full ATOM accuracy suite for PR and main models from ATOM models_accuracy.json
ci:vllm vLLM benchmark: GPT-OSS-120B, DeepSeek-R1-0528, Kimi-K2.5
ci:all All standard extended tests (excludes ci:atom_full)

Only add ci:atom_full for FlyDSL or Triton upgrades.
Add labels via the sidebar or gh pr edit 3455 --add-label <label>

valarLip
valarLip previously approved these changes Jun 8, 2026
@JohnNikolay84 JohnNikolay84 force-pushed the pa_input_vaildation branch from c0621a3 to 33413b8 Compare June 8, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants