Skip to content

docs: fix inaccuracies in hipcc_deprecation.md - #6985

Open
david-salinas wants to merge 1 commit into
mainfrom
users/dsalinas/hipcc-deprecation-doc-fixes
Open

docs: fix inaccuracies in hipcc_deprecation.md#6985
david-salinas wants to merge 1 commit into
mainfrom
users/dsalinas/hipcc-deprecation-doc-fixes

Conversation

@david-salinas

Copy link
Copy Markdown
Contributor

Motivation

Clean up the HIPPC to amdclang++ migration guide.

Technical Details

  • Correct amdclang++ description: it is its own binary (amdllvm), not a symlink to clang++
  • Fix CMAKE_HIP_COMPILER claim: toolchain sets it to clang++, not amdclang++
  • Remove --rtlib=compiler-rt --unwindlib=libgcc references (never landed)
  • Expand rocm_agent_enumerator row to include --offload-arch=native for direct invocation path
  • Add note that --hip-device-lib-path is usually derivable from --hip-path

Test Plan

Test Result

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
JIRA ID (on separate line)
ROCM-25757
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID (on separate line)
AIRUNTIME-2352
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ❌ Fail Error: Check concluded with failure.
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 2 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description
  • ❌ pre-commit

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 30, 2026
@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@david-salinas
david-salinas requested a review from lamb-j July 30, 2026 02:00
@lamb-j

lamb-j commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Need to rebase on the latest TheRock main

- Correct amdclang++ description: it is its own binary (amdllvm), not a
  symlink to clang++
- Fix CMAKE_HIP_COMPILER claim: toolchain sets it to clang++, not amdclang++
- Remove --rtlib=compiler-rt --unwindlib=libgcc references (never landed)
- Expand rocm_agent_enumerator row to include --offload-arch=native for
  direct invocation path
- Add note that --hip-device-lib-path is usually derivable from --hip-path

Co-Authored-By: Claude Sonnet 4 (1M context) <noreply@anthropic.com>
@david-salinas
david-salinas force-pushed the users/dsalinas/hipcc-deprecation-doc-fixes branch from af88f59 to a62d83e Compare July 30, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Not ready to Review PR has unresolved policy failures — reviews blocked

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

2 participants