docs: fix inaccuracies in hipcc_deprecation.md - #6985
Open
david-salinas wants to merge 1 commit into
Open
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
Contributor
|
Need to rebase on the latest TheRock main |
- Correct amdclang++ description: it is its own binary (amdllvm), not a symlink to clang++ - Fix CMAKE_HIP_COMPILER claim: toolchain sets it to clang++, not amdclang++ - Remove --rtlib=compiler-rt --unwindlib=libgcc references (never landed) - Expand rocm_agent_enumerator row to include --offload-arch=native for direct invocation path - Add note that --hip-device-lib-path is usually derivable from --hip-path Co-Authored-By: Claude Sonnet 4 (1M context) <noreply@anthropic.com>
david-salinas
force-pushed
the
users/dsalinas/hipcc-deprecation-doc-fixes
branch
from
July 30, 2026 15:22
af88f59 to
a62d83e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Clean up the HIPPC to amdclang++ migration guide.
Technical Details
Test Plan
Test Result
Submission Checklist