feat(build): add typed ROCm build flag provider protocol - #6984
Open
stellaraccident wants to merge 3 commits into
Open
feat(build): add typed ROCm build flag provider protocol#6984stellaraccident wants to merge 3 commits into
stellaraccident wants to merge 3 commits into
Conversation
Provide one fail-closed build flag contract for integrated and standalone ROCm project builds. Values are resolved while building a library and do not add an installed package dependency. Changes: - Add versioned BOOL and INTEGER provider state and consumer resolution. - Add unconditional aux-overlay C and C++ conformance compilation. - Document adoption, precedence, validation, and distribution boundaries. Tests: - 12 focused Python and CMake fixture tests passed. - Minimal TheRock configure and therock-aux-overlay+build passed. - pre-commit passed for every changed TheRock file.
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
therock-pr-bot
Bot
added
the
Not ready to Review
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
stellaraccident
commented
Jul 30, 2026
Avoid coupling aux-overlay to its current relative location in the source tree. Changes: - Resolve the canonical build flag helper through THEROCK_SOURCE_DIR. Tests: - 7 focused build flag fixture tests passed. - Standalone aux-overlay conformance compilation passed. - Integrated therock-aux-overlay+build passed. - pre-commit passed for the changed file.
stellaraccident
marked this pull request as ready for review
July 30, 2026 01:30
Keep the aux-overlay conformance build within its normal subproject lifecycle and make diagnostic assertions insensitive to platform-specific CMake line wrapping. Changes: - Remove aux-overlay from the top-level priority build target. - Normalize whitespace before checking expected CMake failures. Tests: - 7 focused ROCm build flag tests passed on Linux. - comm-libs stage configuration completed successfully. - pre-commit passed for both changed files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide one fail-closed build flag contract for integrated and standalone ROCm project builds. Values are resolved while building a library and do not add an installed package dependency.
Changes:
Tests: