Skip to content

feat(enable-sanity-step-name): add step metadata to Driver GPU sanity check - #6975

Draft
ndhillon07 wants to merge 1 commit into
mainfrom
users/ndhillon07/label-sanity-check-step
Draft

feat(enable-sanity-step-name): add step metadata to Driver GPU sanity check#6975
ndhillon07 wants to merge 1 commit into
mainfrom
users/ndhillon07/label-sanity-check-step

Conversation

@ndhillon07

Copy link
Copy Markdown
Contributor

Summary

Add environment variable metadata to the Driver / GPU sanity check step in test_component.yml to enable proper step identification and timeout handling in Grafana dashboards and prolense monitoring.

Changes

  • Add STEP_NAME environment variable with Grafana-friendly name (no "/" characters)
  • Add STEP_TIMEOUT_MINUTES to match the step's timeout-minutes value (5 minutes)
  • Add NO_OUTPUT_TIMEOUT for prolense timeout handling (3 minutes)

Motivation

This change aligns the Driver GPU sanity check step with the existing pattern used in the Test step, ensuring consistent monitoring and observability across workflow steps. The step metadata enables:

  • Proper step identification in Grafana dashboards
  • Correct timeout handling by prolense monitoring
  • Consistent observability patterns across all workflow steps

Testing

  • Workflow syntax validated
  • Environment variable pattern matches existing Test step implementation

- Add STEP_NAME for Grafana-friendly step identification
- Add STEP_TIMEOUT_MINUTES matching timeout-minutes value
- Add NO_OUTPUT_TIMEOUT for prolense timeout handling
@therock-pr-bot

therock-pr-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
JIRA ID (on separate line)
ROCM-25757
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID (on separate line)
AIRUNTIME-2352
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 29, 2026
@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Not ready to Review PR has unresolved policy failures — reviews blocked

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

1 participant