Skip to content

Add RFC0013 for code coverage infrastructure in TheRock - #6967

Open
reboss wants to merge 3 commits into
ROCm:mainfrom
reboss:users/jorobbin/code-cov-rfc
Open

Add RFC0013 for code coverage infrastructure in TheRock#6967
reboss wants to merge 3 commits into
ROCm:mainfrom
reboss:users/jorobbin/code-cov-rfc

Conversation

@reboss

@reboss reboss commented Jul 29, 2026

Copy link
Copy Markdown
Member

Proposes per-project coverage builds with isolation to prevent profraw contamination from upstream dependencies, maintaining separate coverage pipeline from pre-checkin testing.

@therock-pr-bot

therock-pr-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
JIRA ID (on separate line)
ROCM-25757
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID (on separate line)
AIRUNTIME-2352
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ❌ Fail Error: Check concluded with failure.
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 2 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description
  • ❌ pre-commit

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 29, 2026
@therock-pr-bot

therock-pr-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

reboss added 3 commits July 29, 2026 10:53
Proposes per-project coverage builds with isolation to prevent profraw
contamination from upstream dependencies, maintaining separate coverage
pipeline from pre-checkin testing.
Emphasize that coverage in one component doesn't affect coverage in
downstream components, balancing the upstream contamination argument.
Add detail that -object flag doesn't accept wildcards (test_*), requiring
explicit expansion. Propose declarative approach with standard test naming
convention as an open discussion topic.
@reboss
reboss force-pushed the users/jorobbin/code-cov-rfc branch from 9b63d52 to 805a2e8 Compare July 29, 2026 17:00
@ScottTodd
ScottTodd self-requested a review July 29, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Not ready to Review PR has unresolved policy failures — reviews blocked

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

1 participant