fix(packaging): merge wsl-rocdxg artifacts into amdrocm-runtime packages - #6947
Open
nunnikri wants to merge 1 commit into
Open
fix(packaging): merge wsl-rocdxg artifacts into amdrocm-runtime packages#6947nunnikri wants to merge 1 commit into
nunnikri wants to merge 1 commit into
Conversation
Remove the separate amdrocm-wsl and amdrocm-wsl-devel packages and fold their wsl-rocdxg artifacts directly into amdrocm-runtime (lib/doc) and amdrocm-runtime-devel (dev). This simplifies the package surface — users no longer need to install a separate WSL package; WSL support is included with the runtime automatically. The artifact is added unconditionally; on non-WSL builds the wsl-rocdxg artifact is simply absent from the staging tree and skipped silently. Co-Authored-By: Claude <noreply@anthropic.com>
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
saadrahim
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the standalone amdrocm-wsl and amdrocm-wsl-devel packages and fold their wsl-rocdxg artifacts directly into amdrocm-runtime and amdrocm-runtime-devel respectively.
JIRA ID : https://amd-hub.atlassian.net/browse/ROCM-25054
Motivation
Having a separate amdrocm-wsl package creates unnecessary friction — users on WSL need to discover and install an extra package on top of the runtime. Since wsl-rocdxg is a core runtime component for WSL users (it provides the DXG bridge library librocdxg.so), it belongs in the runtime package rather than as an optional add-on.
Technical Details
Changes to
build_tools/packaging/linux/package.json:amdrocm-runtime: addedwsl-rocdxgartifact with componentslib,docamdrocm-runtime-devel: addedwsl-rocdxgartifact with componentdevamdrocm-wslandamdrocm-wsl-develpackage entries entirelyThe
wsl-rocdxgartifact is added unconditionally. On non-WSL builds whereTHEROCK_ENABLE_WSL_ROCDXGis not set, the artifact is simply absent from thestaging tree and silently skipped by the packaging scripts — no build failure.
Package mapping:
amdrocm-wsl(wsl-rocdxg lib/doc)amdrocm-runtimeamdrocm-wsl-devel(wsl-rocdxg dev)amdrocm-runtime-develTest Plan
Verify the ci build and make sure amdrocm-wsl packages are not built and getting installed as part of amdrocm-runtime packages