[CI] Diff translator-lit failures vs amd-staging baseline#188
Merged
Conversation
The check-amd-llvm-spirv step is non-blocking because upstream Khronos churn breaks ~1 lit test per week. Today the sticky comment just lists N failing tests and tells the reviewer to compare against amd-staging manually. That's the exact triage we did for #187 (22 lit FAILs, all pre-existing). It also misses the inverse signal — a Khronos-upstream merge PR often *fixes* tests red on amd-staging. Run check-amd-llvm-spirv twice: once with the PR-head translator, then again after swapping the translator subdir to amd-staging tip. Diff the two FAIL lists in the github-script step and partition into: - new (in PR, not in baseline) -- likely caused by this PR - fixed (in baseline, not in PR) -- resolved by this PR - common (in both) -- pre-existing breakage Headline picks the dominant bucket. Sticky comment marker unchanged (<!-- spirv-ci:translator-lit -->), so existing comments update in place. Build dir is reused; CMake reconfigure + ninja incremental keep the second pass cheap (only translator objects rebuild). Falls back to the legacy single-list shape if the baseline run didn't produce a result.
lamb-j
added a commit
to ROCm/llvm-project
that referenced
this pull request
May 8, 2026
The check-amd-llvm-spirv step is non-blocking because upstream Khronos churn breaks ~1 lit test per week. Today the sticky comment just lists N failing tests and tells the reviewer to compare against amd-staging manually. It also misses the inverse signal — a Khronos-upstream merge PR often *fixes* tests red on amd-staging. Run check-amd-llvm-spirv twice: once with the PR-head llvm-project, then again after swapping llvm-project to amd-staging tip. Diff the two FAIL lists in the github-script step and partition into: - new (in PR, not in baseline) -- likely caused by this PR - fixed (in baseline, not in PR) -- resolved by this PR - common (in both) -- pre-existing breakage Headline picks the dominant bucket. Sticky comment marker unchanged (<!-- spirv-ci:translator-lit -->), so existing comments update in place. The translator subdir at llvm/projects/SPIRV-LLVM-Translator/ is untracked from llvm-project's tree, so the baseline `git checkout` of amd-staging leaves the overlay alone. Build dir is reused; CMake reconfigure + ninja incremental keep the second pass bounded by the PR diff size — cheap on small PRs, larger on upstream-merge PRs. Falls back to the legacy single-list shape if the baseline run didn't produce a result. Companion change in the ROCm/SPIRV-LLVM-Translator copy of this workflow: ROCm/SPIRV-LLVM-Translator#188.
Contributor
Contributor
Failing tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
check-amd-llvm-spirvstep is non-blocking because upstream Khronos churn breaks ~1 lit test per week. Today the sticky PR comment just lists N failing tests and asks the reviewer to compare againstamd-stagingmanually — that's exactly the triage we ended up doing for #187 (22 lit FAILs, all pre-existing). It also misses the inverse signal: a Khronos-upstream merge PR often fixes tests that are red onamd-staging, and we'd like that surfaced too.This change runs the translator lit suite twice:
git checkout'ing the translator subdir toamd-stagingtip — incremental rebuild against the same build dir, so the second pass is cheap.The
github-scriptcomment step diffs the two FAIL lists and partitions into three buckets:Headline picks the dominant bucket. Sticky-comment marker (
<!-- spirv-ci:translator-lit -->) unchanged, so existing comments update in place. Falls back to the legacy single-list shape if the baseline run didn't produce a result.The companion change for the
ROCm/llvm-projectcopy of this workflow is in ROCm/llvm-project#2451.