Annotate every AMD customization in llvm-spirv#138
Open
MrSidims wants to merge 2 commits into
Open
Conversation
Contributor
MrSidims
requested review from
AlexVlx,
jmmartinez,
lamb-j,
maarquitos14 and
mgcarrasco
MrSidims
commented
Mar 31, 2026
Contributor
Contributor
|
!PSDB |
Contributor
maarquitos14
approved these changes
Mar 31, 2026
maarquitos14
left a comment
maarquitos14
left a comment
Contributor
There was a problem hiding this comment.
I love this. Thanks for doing it!
Comment on lines
+22
to
+23
| All AMD-specific code is marked with `// AMD customization begin:` and | ||
| `// AMD customization end` comments in the source files. |
Contributor
There was a problem hiding this comment.
Suggested change
| All AMD-specific code is marked with `// AMD customization begin:` and | |
| `// AMD customization end` comments in the source files. | |
| All AMD-specific code is marked with `// AMD customization begin:` and | |
| `// AMD customization end` comments in the source files. Other appropriate comment markers should be used in different file types. |
Contributor
There was a problem hiding this comment.
Or something along these lines.
lamb-j
approved these changes
Apr 1, 2026
jmmartinez
approved these changes
Apr 1, 2026
jmmartinez
left a comment
jmmartinez
left a comment
Contributor
There was a problem hiding this comment.
To be honest, I hate this (cause I'll always forget to add this, as I forget to add . at the end of every comment in the code).
In an ideal world, I'd love to have a cmake flag to enable AMD customizations and have test that cover vanilla vs AMD flavor. But this is a first step to something cleaner.
mgcarrasco
approved these changes
Apr 1, 2026
Collaborator
|
We still want to land this? |
Contributor
Author
I believe - yes. I'll rebase, guard newly added code and re-run tests etc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated by Claude Code.
(please don't review/merge yet as I haven't yet checked the annotations)