Skip to content
This repository was archived by the owner on Jan 26, 2024. It is now read-only.

Install export file so it is available for hip#13

Open
pfultz2 wants to merge 1 commit into
roc-3.5.xfrom
install-export
Open

Install export file so it is available for hip#13
pfultz2 wants to merge 1 commit into
roc-3.5.xfrom
install-export

Conversation

@pfultz2

@pfultz2 pfultz2 commented Jun 11, 2020

Copy link
Copy Markdown

This is necessary to build hip with rocclr.

@pfultz2

pfultz2 commented Jun 16, 2020

Copy link
Copy Markdown
Author

Ping?

@aaronenyeshi

Copy link
Copy Markdown

@pfultz2 looks good to me, but you need to push it to internal branch on Gerrit.
+CC @gargrahul @mangupta

@gandryey

Copy link
Copy Markdown
Contributor

The cmake logic had drastic changes recently. I believe the latest code has proper export already and it will be available in ROCM3.6.

@pfultz2

pfultz2 commented Jun 16, 2020

Copy link
Copy Markdown
Author

but you need to push it to internal branch on Gerrit.

I dont have access to push to that repo. Does this project not accept open source contributions?

@gargrahul

Copy link
Copy Markdown
Collaborator

but you need to push it to internal branch on Gerrit.

I dont have access to push to that repo. Does this project not accept open source contributions?

Are instructions available @ ROCm/hip#2104 (comment) not working for you ?

@pfultz2

pfultz2 commented Jun 16, 2020

Copy link
Copy Markdown
Author

Are instructions available @ ROCm/hip#2104 (comment) not working for you ?

Those instructions of course do not work as they cannot be used by source-based package managers. This PR will fix the issue with the build scripts. I figured it would be more helpful to open a PR instead of an issue. Does rocclr not accept open source contributions?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants