[ROCm] Avoid unsupported BF16 llm_int8 registration#55
Open
austin1997 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Custom Device
PR Types
Bug fixes
Description
This PR avoids advertising BF16 support for the CUDA-only llm_int8_linear GPU kernel on ROCm.
The existing kernel implementation only provides a CUDA path and the non-CUDA path throws Unimplemented at runtime. On ROCm, the BF16 dtype registration allowed BF16 inputs to dispatch into that unsupported path. This change keeps the kernel touch symbol available for the generated code, but only registers phi::bfloat16 for CUDA builds. ROCm now reports BF16 llm_int8_linear as an unregistered kernel instead of entering the CUDA-only implementation.
The Python test skip condition is also centralized and updated so llm_int8_linear tests are skipped on ROCm.
Validation:
是否引起精度变化
否