feat(mesh): add v4 1p1d/2p1d slurm scripts with nightly docker image#1124
Open
Jasen2201 wants to merge 1 commit into
Open
feat(mesh): add v4 1p1d/2p1d slurm scripts with nightly docker image#1124Jasen2201 wants to merge 1 commit into
Jasen2201 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new SLURM job scripts under atom/mesh/scripts/ to run DeepSeek-V4-Pro PD-disaggregated (prefill/decode) benchmarks on ATOM using a specified nightly ROCm Docker image, including an optional GSM8K accuracy run and a serving benchmark loop.
Changes:
- Add a 1P+1D (TP-only) SLURM script for DeepSeek-V4-Pro PD disaggregation on ATOM.
- Add a 2P+1D (DP-attention enabled) SLURM script for DeepSeek-V4-Pro PD disaggregation on ATOM.
- Include end-to-end orchestration: node discovery, container launch, server/router startup, readiness checks, GSM8K eval, and benchmarking.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
atom/mesh/scripts/ds_v4_2p_tp8_1d_tp8_atom_dpa_slurm.sh |
New 3-node (2 prefill + 1 decode) DP-attention PD-disaggregation SLURM workflow using a nightly Docker image. |
atom/mesh/scripts/ds_v4_1p_tp8_1d_tp8_atom_tp_slurm.sh |
New 2-node (1 prefill + 1 decode) pure-TP PD-disaggregation SLURM workflow using a nightly Docker image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+21
to
+23
| # Usage: | ||
| # mkdir -p /it-share/yajizhan/slurm_logs | ||
| # sbatch ds_v4_2p_tp8_1d_tp8_atom_dpa_slurm.sh |
Comment on lines
+20
to
+22
| # Usage: | ||
| # mkdir -p /it-share/yajizhan/slurm_logs | ||
| # sbatch ds_v4_1p_tp8_1d_tp8_atom_tp_slurm.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist