Skip to content

ci: skip ATOM Test for plugin-only PRs#1099

Open
gyohuangxin wants to merge 4 commits into
mainfrom
skip-atom-test-plugin-only
Open

ci: skip ATOM Test for plugin-only PRs#1099
gyohuangxin wants to merge 4 commits into
mainfrom
skip-atom-test-plugin-only

Conversation

@gyohuangxin
Copy link
Copy Markdown
Member

@gyohuangxin gyohuangxin commented Jun 5, 2026

Summary

  • Skip native ATOM Test for plugin-only and plugin-test-only PRs.
  • Route plugin-only PRs to the targeted plugin test workflow: SGLang-only changes run SGLang, vLLM-only changes run vLLM, and shared atom/plugin changes run both.
  • Preserve full PR coverage for all other changes by letting native, vLLM, and SGLang tests all run when a PR includes any non-special path.

Routing

  • atom/plugin/sglang/** only -> ATOM SGLang Test only.
  • atom/plugin/vllm/** only -> ATOM vLLM Test only.
  • shared atom/plugin/** only -> ATOM vLLM Test and ATOM SGLang Test.
  • atom-sglang-* workflow or sglang_models_accuracy.json only -> ATOM SGLang Test only.
  • atom-vllm-* workflow or oot_models_accuracy.json only -> ATOM vLLM Test only.
  • Any mixed or other code path -> full native + vLLM + SGLang test coverage.

Test plan

  • Ran git diff --check.
  • Simulated representative paths-ignore cases locally for SGLang-only, vLLM-only, shared plugin, special workflow/config, and mixed/full-run changes.

Copilot AI review requested due to automatic review settings June 5, 2026 08:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ATOM Test GitHub Actions workflow to avoid running native test CI for pull requests that only touch plugin code under atom/plugin/**, reducing unnecessary CI load while keeping existing behavior for other PRs and for scheduled/manual runs.

Changes:

  • Add atom/plugin/** to pull_request.paths-ignore in ATOM Test workflow so plugin-only PRs don’t trigger this workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings June 5, 2026 09:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread .github/workflows/atom-vllm-test.yaml Outdated
Comment on lines +10 to +12
- 'atom/plugin/sglang/**'
- '.github/workflows/atom-sglang-*.yaml'
- '.github/benchmark/oot_models_accuracy.json'
Comment thread .github/workflows/atom-sglang-test.yaml Outdated
Comment on lines +10 to +12
- 'atom/plugin/vllm/**'
- '.github/workflows/atom-vllm-*.yaml'
- '.github/benchmark/sglang_models_accuracy.json'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants